Random updates #696
Merged
Random updates #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AdamTheisen
commented
Jul 7, 2023
•
AdamTheisen
commented
- Documentation reflects changes
- PEP8 Standards or use of linter
- Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming
… so we need to do the conversion
…g corrections, to the addition of the get_arm.py discovery module to deprecate get_armfiles.py and move that are to a move consistent naming.
mgrover1
reviewed
Jul 7, 2023
There was a problem hiding this comment.
@AdamTheisen - this will change the API - should we create a v2 tag and pull request to that instead of main?
|
@mgrover1 @AdamTheisen its a duplicate file and one has a warning, the api won't change on the user's end besides a new warning, and the replacement will also exist. |
|
@mgrover1 what @zssherman said! :). Shouldn't change the API at the moment. Figured that we would do some cleanup with V2. |
|
Okay! Great! I wasn't sure if we wanted to create that separate branch for now - but it sounds like that is a no, so I can go ahead and approve! |
mgrover1
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.