-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: Adding new example for working with ARM QC and Xarray Transforma… #734
Conversation
…tions. Updating one example to follow ds convention, and fixing warn message for armfiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment - otherwise, this looks great!
@kenkehoe just wanted to ping you on this example. Was something like this what you were thinking? |
@mgrover1 does this look good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes here!
@AdamTheisen overall I think it looks good. I didn't actually run the code so I don't know what the plot looks like. Does the updated QC work? |
@kenkehoe the updated qc will not work which is what I try to note in the example and why users should filter their data appropriately ahead of any transformation |
@AdamTheisen OK sounds good. Thanks for the example. |
…tions. Updating one example to follow ds convention, and fixing warn message for armfiles