Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix to resolve #750 for older ARM qc convention in files #755

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

AdamTheisen
Copy link
Collaborator

@AdamTheisen AdamTheisen commented Nov 17, 2023

@AdamTheisen
Copy link
Collaborator Author

@kenkehoe @zssherman I think i have a fix in and working for the Old QC standards (or lack of standards that is). Let me know what you think.

@kenkehoe
Copy link
Contributor

Looks good. Do you need to set the Dataset variable big_#description and bit#_assessment attributes? We don't set those for other QC variables when we use flag_values, flag_meanings, flag_assessents.

@AdamTheisen
Copy link
Collaborator Author

Looks good. Do you need to set the Dataset variable big_#description and bit#_assessment attributes? We don't set those for other QC variables when we use flag_values, flag_meanings, flag_assessents.

@kenkehoe good question. I thought there was an error when I did but I ran it without it and worked. I'll remove that to simplify things

@AdamTheisen AdamTheisen merged commit 402389d into ARM-DOE:main Nov 17, 2023
16 checks passed
@AdamTheisen AdamTheisen deleted the old_qc branch November 17, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while using add_dqr_to_qc: flag_values and flag_masks not set as expected
3 participants