Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Reorganize the entire test module. #771

Merged
merged 15 commits into from
Dec 14, 2023

Conversation

zssherman
Copy link
Collaborator

@zssherman zssherman commented Dec 13, 2023

Reorganize test module so that each module has its own test file. This allows for separation and easier debugging. Also fixed a few functions missing from init.py 's and broken tests etc.

  • Closes Reorganize the Unit Tests #731
  • Tests added
  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

Copy link
Collaborator

@AdamTheisen AdamTheisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Thanks for the effort here! We should double check the unit test coverage results before merging to make sure everything lines up with expectations

@zssherman
Copy link
Collaborator Author

zssherman commented Dec 13, 2023

@AdamTheisen So some of the tests break due to overlap in naming, I suggest and changed the names of overlapping test to match the module so test_arm.py in io and test_arm.py in qc, now test_arm.py in qc is test_arm_qc.py to fix the overlap.

@AdamTheisen AdamTheisen merged commit 8c5fa72 into ARM-DOE:main Dec 14, 2023
16 checks passed
@zssherman zssherman deleted the test_organize branch January 23, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize the Unit Tests
2 participants