Base functionality to create movies from images #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AdamTheisen
commented
Dec 18, 2023
•
AdamTheisen
commented
- Closes Function to create movies #469
- Tests added
- Documentation reflects changes
- PEP8 Standards or use of linter
- Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming
zssherman
requested changes
Dec 18, 2023
|
I had a feeling that the test was not going to work on Windows... I'll try and test that out some more when I get a chance. |
|
@zssherman this should be good to go for another review! @kenkehoe we can test this out as an optional dependency for now and can always adjust in the future. You can pass it a list of images or a list of URLs and is pretty straight forward at the moment. |
zssherman
approved these changes
Dec 19, 2023
|
@AdamTheisen Looks good to me now! Feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.