Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Updating tests for plotting to increase coverage #777

Merged
merged 1 commit into from
Dec 20, 2023
Merged

ENH: Updating tests for plotting to increase coverage #777

merged 1 commit into from
Dec 20, 2023

Conversation

AdamTheisen
Copy link
Collaborator

@AdamTheisen AdamTheisen commented Dec 20, 2023 •
edited
Loading

  • Tests added
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

zssherman
zssherman approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@zssherman zssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @AdamTheisen ! Feel free to merge

@AdamTheisen AdamTheisen merged commit bbd2488 into ARM-DOE:main Dec 20, 2023
16 checks passed
@AdamTheisen AdamTheisen deleted the tests branch December 20, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zssherman zssherman zssherman approved these changes

@mgrover1 mgrover1 Awaiting requested review from mgrover1 mgrover1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamTheisen @zssherman