ENH: New baseline images and updates to plot test tolerances #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AdamTheisen
commented
Feb 14, 2024
•
AdamTheisen
commented
- Closes Verify that unit tests for plotting are comparing and doing what it's supposed to. #768
- PEP8 Standards or use of linter
- Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming
zssherman
reviewed
Feb 14, 2024
|
@zssherman I was thinking the same thing the more I look at it. This was one where we had a tolerance of 81 set so it has previously been problematic. |
zssherman
reviewed
Feb 14, 2024
|
Yeah, we can investigate! I only see the two specific examples, so I can test them out and check the module. |
zssherman
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.