Align kernel_sum/ effective_bias useage #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use kernel_sum[i] = SUM_j(kernel[i][j]*input_offset + input_offset*filter_offset) + bias[i] for all occurences of kernel_sums in int8 operators, mirroring the behavour of effective_bias in the LSTM operator. This avoids one extra read/write per output. Change-Id: If31c3122b7b6bfaa8a1632436d31d20937d6c13d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
kernel_sum[i] = SUM_j(kernel[i][j]input_offset + input_offsetfilter_offset) + bias[i]
for all occurrences of kernel_sums in int8 operators, mirroring the behavior of effective_bias in the LSTM operator. This avoids one extra read/write per output.