Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MPU macros and improving docs #1617

Merged
3 commits merged into from
Apr 13, 2023

Conversation

M-Plichta
Copy link
Contributor

Functional changes:

  • There already were macros for MPU_RBAR shareability field (ARM_MPU_SH_NON, ARM_MPU_SH_OUTER and ARM_MPU_SH_INNER), so I added macros for the access permissions and execute-never fields.
  • Added some handy functions and macros for better readability, like ARM_MPU_TYPE function and the macro MAIR_ATTR.
  • Added input macros for ARM_MPU_ATTR

Docs:

  • Changed wording for clarity and consistency with the Architecture Reference Manual.

@M-Plichta
Copy link
Contributor Author

M-Plichta commented Apr 10, 2023

If the changes are accepted, examples will have to be changes, like the ones in Ref_MPU8.txt, which I'll do in separate pull requests.

@ghost ghost self-requested a review April 11, 2023 11:20
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update version and date in the header section.

@M-Plichta
Copy link
Contributor Author

Hey @GuentherMartin, thanks for the comment.

What's wrong with the CoreValidation test?
This is my first pull request so I can't quite work out why it's failing.

Thanks

@ARM-software ARM-software deleted a comment from grasci-arm Apr 13, 2023
@ghost ghost merged commit 1ee8b28 into ARM-software:develop Apr 13, 2023
@ghost
Copy link

ghost commented Apr 13, 2023

Hello @M-Plichta, there are some problems within the test environment. I will try to run the tests manually.

@M-Plichta M-Plichta deleted the mpu-improvements branch April 13, 2023 12:44
@M-Plichta M-Plichta mentioned this pull request Apr 16, 2023
JiafeiPan pushed a commit to nxp-mcuxpresso/CMSIS_5 that referenced this pull request Aug 8, 2023
* Adding MPU macros and improving docs

* Edited the comments as per Edmund's comments

* Updating the version and date

---------

Co-authored-by: Miłosz Plichta <milosz.plichta@arm.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants