Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decimal float support #114

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Add decimal float support #114

merged 1 commit into from
Oct 22, 2021

Conversation

rearnsha
Copy link

Add support to the ABI for the Decimal Float data types as proposed in C2x drafts.

Copy link
Member

@stuij stuij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@stuij stuij merged commit 113d96b into ARM-software:main Oct 22, 2021
@@ -1939,3 +1975,6 @@ Footnotes

.. [#aapcs64-f7]
This includes double-precision or smaller floating-point values and 64-bit short vector values.

.. [#aapcs64-f8]
The Advanced SIMD Extension does not provide any vector operations for Decimal Floating-point types, so short vector types are not defined for these.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are not defined.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I feel removing 'for these' changes the meaning of the sentence. Then to me it now reads like short vector types would not be defined at all, and that is not the case as they would still be defined for other types.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be changed to '... so short vector types for these are not defined'.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just add 'types' to the end of the sentence... 'for these types.'

Copy link

@sallyarmneale sallyarmneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three minor corrections

stuij added a commit that referenced this pull request Oct 28, 2021
this patch addresses issues raised in
#114
stuij added a commit that referenced this pull request Oct 28, 2021
this patch addresses issues raised in
#114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants