-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decimal float support #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@@ -1939,3 +1975,6 @@ Footnotes | |||
|
|||
.. [#aapcs64-f7] | |||
This includes double-precision or smaller floating-point values and 64-bit short vector values. | |||
|
|||
.. [#aapcs64-f8] | |||
The Advanced SIMD Extension does not provide any vector operations for Decimal Floating-point types, so short vector types are not defined for these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are not defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I feel removing 'for these' changes the meaning of the sentence. Then to me it now reads like short vector types would not be defined at all, and that is not the case as they would still be defined for other types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be changed to '... so short vector types for these are not defined'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just add 'types' to the end of the sentence... 'for these types.'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
three minor corrections
this patch addresses issues raised in #114
this patch addresses issues raised in #114
Add support to the ABI for the Decimal Float data types as proposed in C2x drafts.