aapcs64-morello: Fix up rule C.8 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the wording of rule C.8 didn't allow passing a capability in C7 in the case where the NGRN is 7 (i.e. when C0 through C6 are already allocated). This change relaxes the rule, instead of requiring that the size of the argument be strictly less than 16 * (8 - NGRN), we only require it to be less than or equal to this value, which I believe gives the intended behaviour. We also take the opportunity to avoid using the "quad words" terminology which can be considered ambiguous.
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the wording of rule C.8 didn't allow passing a capability
in C7 in the case where the NGRN is 7 (i.e. when C0 through C6 are already
allocated). This change relaxes the rule, instead of requiring that the size of
the argument be strictly less than 16 * (8 - NGRN), we only require it to be
less than or equal to this value, which I believe gives the intended behaviour.
We also take the opportunity to avoid using the "quad words" terminology which
can be considered ambiguous.