-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor modification to FMV rules for scope and signatures #363
base: main
Are you sure you want to change the base?
Conversation
9f40b3a
to
a0a77a9
Compare
I have updated this PR with (hopefully) clearer wording more inline with @labrinea 's suggestions. |
a0a77a9
to
5752052
Compare
I have changed the rule for whats allowed signature wise after a suggestion by @rsandifo-arm which makes it more precise in terms of function types and added some examples. Specifically, the rule change specifies compatibility in terms of if the types are compatible, and the example shows this in terms of function pointers. |
5752052
to
a34b492
Compare
a34b492
to
ad06c49
Compare
If no objections are raised, let's merge this on the 23 December. |
ad06c49
to
03048e4
Compare
Changes the Function multiversioning rules for `target_version` such that the signature and scope for a set of FMV functions is that of the default version. This patch also adds some examples documenting the rules and behavior.
03048e4
to
513982a
Compare
Hi all,
While attempting to implement FMV in the GCC front-end some questions were raised that I think are worth clarifying here.
This PR changes the rules to use the default function to determine the signature and scope of the versioned function set.
This clears up some cases such as:
Where there are conflicting signatures and which default should be used is not clear at the moment.
Where if this should be considered a conflicting signature is not clear.
Where the scope of multi-versioned functions differs.
And
Where it is possible calls in different TU's could use different default argument values.
name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.
Thank you for submitting a pull request!
If this PR is about a bugfix:
Please use the bugfix label and make sure to go through the checklist below.
If this PR is about a proposal:
We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.
We would like to encourage you reading through the contribution
guidelines, in particular the section on submitting
a proposal.
Please use the proposal label.
As for any pull request, please make sure to go through the below
checklist.
Checklist: (mark with
X
those which apply)PR (do not bother creating the issue if all you want to do is
fixing the bug yourself).
SPDX-FileCopyrightText
lines on topof any file I have edited. Format is
SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>
(Please update existing copyright lines if applicable. You can
specify year ranges with hyphen , as in
2017-2019
, and usecommas to separate gaps, as in
2018-2020, 2022
).Copyright
section of the sources of thespecification I have edited (this will show up in the text
rendered in the PDF and other output format supported). The
format is the same described in the previous item.
tricky to set up on non-*nix machines). The sequence can be
found in the contribution
guidelines. Don't
worry if you cannot run these scripts on your machine, your
patch will be automatically checked in the Actions of the pull
request.
introduced in this PR in the section Changes for next
release of the section Change Control/Document history
of the document. Create Changes for next release if it does
not exist. Notice that changes that are not modifying the
content and rendering of the specifications (both HTML and PDF)
do not need to be listed.
correctness of the result in the PDF output (please refer to the
instructions on how to build the PDFs
locally).
draftversion
is set totrue
in the YAML headerof the sources of the specifications I have modified.
in the README page of the project.