-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FMV] Document feature dependencies and detect at selection. #368
[FMV] Document feature dependencies and detect at selection. #368
Conversation
1c12694
to
ab5ca42
Compare
i8mm -> simd fp16fml -> simd frintts -> fp bf16 -> simd sme -> fp16 Approved in ACLE as ARM-software/acle#368
#119231) i8mm -> simd fp16fml -> simd frintts -> fp bf16 -> simd sme -> fp16 Approved in ACLE as ARM-software/acle#368
| sha3 | sha2 | | ||
| aes | simd | | ||
| fp16 | fp | | ||
| fp16fml | simd, fp16 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last time I checked, I don't think any part of the toolchains has an fp16fml->simd dependency for command line arguments, so this seems inconsistent.
| rcpc3 | rcpc2 | | ||
| frintts | fp | | ||
| i8mm | simd | | ||
| bf16 | simd | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In GCC+Bintuils we only have bf16 depending on fp, and in LLVM it depends on nothing at all. I think fp is more appropriate than simd.
| frintts | fp | | ||
| i8mm | simd | | ||
| bf16 | simd | | ||
| sve | fp16 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably have a simd dependency, and perhaps also an fcma dependency?
| sve2-bitperm | sve2 | | ||
| sve2-sha3 | sve2, sha3 | | ||
| sve2-sm4 | sve2, sm4 | | ||
| sme | fp16, bf16 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't currently match existing command line options, but those should probably be adjusted. Should this also have a simd and perhaps fcma dependency?
* the depended-on feature *may* be specified in the attribute. | ||
|
||
These dependencies are taken into account transitively when selecting the | ||
most appropriate version of a function (see section [Selection](#selection)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with this - while it's unlikely to come up in practice, I think the selection algorithm would be simpler to understand if it were based solely upon the attribute strings and the feature priorities, without trying to detect and ignore any redundant dependencies.
name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.
Thank you for submitting a pull request!
If this PR is about a bugfix:
Please use the bugfix label and make sure to go through the checklist below.
If this PR is about a proposal:
We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.
We would like to encourage you reading through the contribution
guidelines, in particular the section on submitting
a proposal.
Please use the proposal label.
As for any pull request, please make sure to go through the below
checklist.
Checklist: (mark with
X
those which apply)PR (do not bother creating the issue if all you want to do is
fixing the bug yourself).
SPDX-FileCopyrightText
lines on topof any file I have edited. Format is
SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>
(Please update existing copyright lines if applicable. You can
specify year ranges with hyphen , as in
2017-2019
, and usecommas to separate gaps, as in
2018-2020, 2022
).Copyright
section of the sources of thespecification I have edited (this will show up in the text
rendered in the PDF and other output format supported). The
format is the same described in the previous item.
tricky to set up on non-*nix machines). The sequence can be
found in the contribution
guidelines. Don't
worry if you cannot run these scripts on your machine, your
patch will be automatically checked in the Actions of the pull
request.
introduced in this PR in the section Changes for next
release of the section Change Control/Document history
of the document. Create Changes for next release if it does
not exist. Notice that changes that are not modifying the
content and rendering of the specifications (both HTML and PDF)
do not need to be listed.
correctness of the result in the PDF output (please refer to the
instructions on how to build the PDFs
locally).
draftversion
is set totrue
in the YAML headerof the sources of the specifications I have modified.
in the README page of the project.