Skip to content

Commit

Permalink
Terminal browser: swap minibuffer prompts for p and P.
Browse files Browse the repository at this point in the history
In a trace buffer, 'p' prompts for a pc value, and jumps to the
next (later in time) occasion when that pc is visited. The capital
version, 'P', does the same thing except that it jumps earlier in
time.

Unfortunately, their minibuffer prompts are back to front. 'p' was
prompting "Go to previous visit to PC: ", and 'P' said "next", which
is the opposite of what each one really does.

I think it's all consistent now. The actual behaviour, the F10 help,
and the minibuffer prompts all point in the same direction.
  • Loading branch information
statham-arm committed Feb 9, 2024
1 parent 48cfd44 commit 75288d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion browser/curses.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1062,7 +1062,7 @@ class TraceBuffer : public Window {
return true;
} else if (c == 'p' || c == 'P') {
screen->minibuf_ask(
(c == 'p' ?
(c == 'P' ?
_("Go to previous visit to PC: ") :
_("Go to next visit to PC: ")), this);
minibuf_reqtype = c;
Expand Down

0 comments on commit 75288d2

Please sign in to comment.