-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lpc4322 cleanups for GCC #813
Conversation
Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
It provides GetClockFreq() which is needed by USART_LPC43xx.
this provides definitions needed by GetClockFreq()
Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
This way, one can set SWO_UART from the target's yaml. Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
The stack and heap have to reside in m_data. The largest symbols (.bss.TraceBuf, .bss.sector_buf, .bss.DAP_Cmd_queue) are explicitly placed in m_data_2. Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
I have tentatively re-worked this PR in mathias-arm:feature/lpc4322_enhancements:
I have done some light testing with I do have a few additional questions which might be addressed at a later date:
|
The removal of |
@groleo: If you are okay with my changes can you force-push them to this PR? |
I don't see why not. I'll try to test 180 MHz sometime this week.
On LPC4322 the bottleneck is not the buffer-size, but the bit-banging SWD implementation.
additional changes are in the rt1170 patches. |
My question came out wrong. There might be good reasons to use a lower frequency (lower power, no performance, increased stability, etc.), I was wondering if you had some insight on the trade-offs for the LPC4322.
This define comes from CMSIS-DAP, but DAPLink is missing some of bits that are needed to make it work (e.g. start |
|
If you can validate my branch and push it to this PR (with possible amendments) I will merge it.
There might be a better use for that RAM then. In [23fed18] I needed to run a few functions from RAM, and it is quite easy to do. We should probably have a macro definition and conditionally put it on the most performance sensitive functions.
@flit has taken a stab at it but it does not work yet.
Nice.
You should create a separate PR for the MIMXRT1170-EVK to replace #712. |
I pushed this change in a branch instead: mathias-arm:feature/lpc4322_cgu I rebased both branches. |
@groleo: I rebased mathias-arm:feature/lpc4322_enhancements on Currently the additional commit in mathias-arm:feature/lpc4322_cgu breaks CDC functionality. So we can postpone this. |
Superseded by #904 |
No description provided.