Edits - with a couple of comments #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
Based on the main repo's master version, with edits to the API.
| */ | ||
| class BLE | ||
| { | ||
| public: | ||
| typedef unsigned InstanceID_t; /** The type returned by BLE::getInstanceID(). */ |
There was a problem hiding this comment.
These lines already exist in the latest BLE_API. Why is your pull request trying to add them? There seems to be a problem with the PR. Did you start out with a clean copy of 'master'? Please re-submit.
There was a problem hiding this comment.
I did what you told me to do.
|
merged to the develop branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In blecommon.h: There are a few error messages without a comment (lines
125-127).
In DiscoveredCharacteristic.h: I changed the “else” to “or” a few
times, because it looked like the
distinction was unnecessary and using two different words can cause
confusion. If there’s really a reason the second return value is “else”
and all the rest are “or”, please reject those changes.
DiscoveredService.h: Looks like it could use some info.
I also sent lots of questions over e-mail.