Hotfix for backward compatibility #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for change from Gap:AddressType_t to BLEProtocol::AddressType_t
| @@ -57,7 +57,7 @@ class Gap { | |||
| * deprecated state to transparenly support existing applications which may | |||
| * have used Gap::ADDR_TYPE_*. | |||
| */ | |||
| enum { | |||
| enum AddressTypeOverload_t { | |||
There was a problem hiding this comment.
@LiyouZhou The whole idea of making this enum anonymous is to deprecate it. What exactly is the situation that you would like to support?
There was a problem hiding this comment.
The error I'm trying to correct is:
/work/iot/ble-examples/BLE_LEDBlinker/source/main.cpp: In function 'void advertisementCallback(const Gap::AdvertisementCallbackParams_t*)':
/work/iot/ble-examples/BLE_LEDBlinker/source/main.cpp:38:93: error: no matching function for call to 'Gap::connect(Address_t, Gap::<anonymous enum>, NULL, NULL)'
BLE::Instance().gap().connect(params->peerAddr, Gap::ADDR_TYPE_RANDOM_STATIC, NULL, NULL);
^
/work/iot/ble-examples/BLE_LEDBlinker/source/main.cpp:38:93: note: candidate is:
In file included from /work/iot/ble-examples/BLE_LEDBlinker/yotta_modules/ble/ble/BLE.h:21:0,
from /work/iot/ble-examples/BLE_LEDBlinker/source/main.cpp:18:
/work/iot/ble-examples/BLE_LEDBlinker/yotta_modules/ble/ble/Gap.h:265:25: note: virtual ble_error_t Gap::connect(const uint8_t*, BLEProtocol::AddressType_t, const Gap::ConnectionParams_t*, const GapScanningParams*)
virtual ble_error_t connect(const BLEProtocol::Address_t peerAddr,
^
/work/iot/ble-examples/BLE_LEDBlinker/yotta_modules/ble/ble/Gap.h:265:25: note: no known conversion for argument 2 from 'Gap::<anonymous enum>' to 'BLEProtocol::AddressType_t {aka BLEProtocol::AddressType::Type}'
/work/iot/ble-examples/BLE_LEDBlinker/source/main.cpp: At global scope:
/work/iot/ble-examples/BLE_LEDBlinker/source/main.cpp:111:26: warning: unused parameter 'ble' [-Wunused-parameter]
void onBleInitError(BLE &ble, ble_error_t error)
^
/work/iot/ble-examples/BLE_LEDBlinker/source/main.cpp:111:43: warning: unused parameter 'error' [-Wunused-parameter]
void onBleInitError(BLE &ble, ble_error_t error)
^
ninja: build stopped: subcommand failed.
There was a problem hiding this comment.
Liyou, could you rename AddressTypeOverload_t into DeprecatedAddressType_t or something like this ?
I would be very happy if we all start to use the __deprecated_message from compiler-polyfill. More information here: #152
|
@andresag01 @pan- please review |
pan-
added a commit
that referenced
this pull request
Dec 23, 2015
Hotfix for backward compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for change from Gap:AddressType_t to BLEProtocol::AddressType_t
@pan- @andresag01 please review.