Invalid adv payloads are not committed before checking #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 19, 2016 10:54
Gap function members that modify the advertising and scan payload use the underlying stack to test if the new payload is sane. If any errors are generated, then the changes are not committed to copy of the payload in BLE API.
|
I'm happy with this |
pan-
added a commit
that referenced
this pull request
Jan 22, 2016
Invalid adv payloads are not committed before checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid advertising payloads are no longer committed to the local copy of the advertising and scan payloads in BLE API before the contents are checked by the underlying stack. The Gap member functions changed are:
Furthermore, startAdvertising() no longer sets the payload in the underlying stack because the payload is set every time it is updated. Finally, the shorthand private member setAdvertisingData(void) is removed from Gap as it is redundant.
@pan-