Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uribeacon update #25

Merged
merged 6 commits into from
Feb 13, 2015
Merged

Uribeacon update #25

merged 6 commits into from
Feb 13, 2015

Conversation

schilit
Copy link
Contributor

@schilit schilit commented Jan 24, 2015

remove methods that update while running config service, this is an unlikely use case
fix characteristics table to include all
rename const UUIDs to fit naming style
don't assume URI is a URL and remove encoding methods
add defaults, which are used for reset, as distrinct from params
Use new style of readonly writeonly characteristic declarations
let caller manage the advertising for both Config mode and Beacon
astyle formatting

@schilit
Copy link
Contributor Author

schilit commented Jan 28, 2015

Ok, changed to unsigned.

@rgrover
Copy link
Contributor

rgrover commented Jan 28, 2015

Hi Bill,

I've been travelling in these last few days, which has prevented me from
reviewing your pull request carefully.

rohit.

On Wed, Jan 28, 2015 at 4:45 PM, Bill Schilit notifications@github.com
wrote:

Ok, changed to unsigned.


Reply to this email directly or view it on GitHub
#25 (comment).

@schilit
Copy link
Contributor Author

schilit commented Jan 28, 2015

Ok, I've been traveling too!

Bill

On Wed, Jan 28, 2015 at 9:42 AM, Rohit Grover notifications@github.com
wrote:

Hi Bill,

I've been travelling in these last few days, which has prevented me from
reviewing your pull request carefully.

rohit.

On Wed, Jan 28, 2015 at 4:45 PM, Bill Schilit notifications@github.com
wrote:

Ok, changed to unsigned.


Reply to this email directly or view it on GitHub
#25 (comment).


Reply to this email directly or view it on GitHub
#25 (comment).

@schilit
Copy link
Contributor Author

schilit commented Jan 28, 2015

Done

rgrover added a commit that referenced this pull request Feb 13, 2015
@rgrover rgrover merged commit bfb66e1 into ARMmbed:master Feb 13, 2015
jacobrosenthal pushed a commit to jacobrosenthal/ble that referenced this pull request Dec 24, 2017
Fix goroutine leak in linux att server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants