make the library less dependent on the mbed.h header #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you consider amending your pull request with the following? diff --git a/services/UARTService.h b/services/UARTService.h
index 8f59948..e9a1a05 100644
--- a/services/UARTService.h
+++ b/services/UARTService.h
@@ -17,6 +17,7 @@
#ifndef __BLE_UART_SERVICE_H__
#define __BLE_UART_SERVICE_H__
+#include "mbed.h"
#include "Stream.h"
#include "UUID.h"
|
|
Sorry. The line needs to be kept. I will add it. |
rgrover
added a commit
that referenced
this pull request
Nov 20, 2014
make the library less dependent on the mbed.h header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, only UARTService.h depends on the mbed library. We can compile the library with the makefile - https://gist.github.com/xiongyihui/0c82af0c4555c11df226