Eddystone Service Working #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to switch back to a working version; but the code being shadowed by this pull request reads better and has several structural improvements which I'd like to see in the eventual Eddystone service. |
|
merged into develop. |
|
Understood, I'll modify my github setup. This is definitely a short term On Tue, Aug 11, 2015, 9:04 AM Rohit Grover notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverted eddystone service to pre-existing version that is known working.
Pro
it works
Con
it does not play nice with other services, as of right now if you use eddystone it is the only service you can have on your device. Will revisit this in the near future to fix.
Changes