adding an initial prototype for a yotta-config based initialization f… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or BLE transports
|
there's one thing which I don't like about the current solution: for non-yotta builds, we will only support a single entry and a single name in the instanceConstructors array. Please comment. |
|
As this is all very experimental, I think it looks good, and I'm interested to see how it works in the wild! re: non-yotta builds ands instanceConstructors/createBLEInstance – you could allow people to define a macro overriding createBLEInstance into a comma separated list? |
|
@autopulated thanks for the review. I'll push it out to ble. |
rgrover
added a commit
that referenced
this pull request
Sep 8, 2015
adding an initial prototype for a yotta-config based initialization f…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or BLE transports
@autopulated: Could you please take a look? In particular, I'd like your input on how I've used the config to drive this.