Move Git history view to SCM package #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nigel Westbury <nigelipse@miegel.org>
mcgordonite
reviewed
Oct 18, 2019
mcgordonite
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes to move the Git history view to the SCM package, refactoring out the Git-specific code. ScmHistorySupport interface has been created as the interface between the widget and the Git implementation.
This is almost identical to the PR into Theia (eclipse-theia#6381). There are some differences as that one is based off current Theia master so some updates to resolve merge conflicts.
This is merging our current release branch into a new branch. It was done like this so the code is available in release-0.9.0 for testing but also we wanted to review privately and separately from the PR into eclipse-theia master.