Merge pull request #18 from dgryski/fuzz-crashers

Fix crashers found by go-fuzz

color.go

@@ -56,6 +56,10 @@ func (color *Color) readNameLen(r io.Reader) error {
 
 // Decode the color's name.
 func (color *Color) readName(r io.Reader) (err error) {
+	if color.nameLen == 0 {
+		return
+	}
+
 	//	make array for our color name based on block length
 	name := make([]uint16, color.nameLen) // assumes the nameLen was already defined.
 	if err = binary.Read(r, binary.BigEndian, &name); err != nil {

fuzz.go

@@ -0,0 +1,14 @@
+// +build gofuzz
+
+package ase
+
+import "bytes"
+
+func Fuzz(data []byte) int {
+
+	if _, err := Decode(bytes.NewReader(data)); err != nil {
+		return 0
+	}
+
+	return 1
+}

fuzz_test.go

@@ -0,0 +1,18 @@
+package ase
+
+import (
+	"strings"
+	"testing"
+)
+
+func TestFuzzCrashers(t *testing.T) {
+
+	var crashers = []string{
+		"ASEF\x00\x01000000\xc0\x010000\x00\x00",
+		"ASEF00\x00\x000000\x00\x010000\x00\x00",
+	}
+
+	for _, f := range crashers {
+		Decode(strings.NewReader(f))
+	}
+}

group.go

@@ -29,6 +29,10 @@ func (group *Group) readNameLen(r io.Reader) error {
 
 // Decode a group's name.
 func (group *Group) readName(r io.Reader) (err error) {
+	if group.nameLen == 0 {
+		return
+	}
+
 	//	make array for our color name based on block length
 	name := make([]uint16, group.nameLen)
 	if err = binary.Read(r, binary.BigEndian, &name); err != nil {