Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise max S2 filename length to 25 #1026

Merged
merged 5 commits into from
May 19, 2022
Merged

Revise max S2 filename length to 25 #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b372e6
Revise max S2 filename length to 25
forrestfwilliams May 19, 2022
490f97b
refactor tests
forrestfwilliams May 19, 2022
5a6df5d
update CHANGELOG
forrestfwilliams May 19, 2022
3276a13
fix typo in test_submit_job
forrestfwilliams May 19, 2022
f8ddcc2
Update CHANGELOG.md
forrestfwilliams May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.17.3]
### Fixed
AUTORIFT jobs can now be submitted for Sentinel-2 scenes with 25-character Earth Search names. Fixes [#1022](https://github.com/ASFHyP3/hyp3/issues/1022).

## [2.17.2]
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion job_spec/AUTORIFT.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ AUTORIFT:
type: string
pattern: "^S2[AB]_.*_L1C"
minLength: 23
maxLength: 24
maxLength: 25
example: S2A_22WEB_20200627_0_L1C
- description: The name of the Landsat 8 or 9 Collection 2 granule to process
type: string
Expand Down
2 changes: 1 addition & 1 deletion job_spec/AUTORIFT_ITS_LIVE.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ AUTORIFT:
type: string
pattern: "^S2[AB]_.*_L1C"
minLength: 23
maxLength: 24
maxLength: 25
example: S2A_22WEB_20200627_0_L1C
- description: The name of the Landsat 8 or 9 Collection 2 granule to process
type: string
Expand Down
7 changes: 7 additions & 0 deletions tests/test_api/test_submit_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ def test_submit_good_autorift_granule_names(client, tables):
'S2A_MSIL1C_20200627T150921_N0209_R025_T22WEB_20200627T170912',
'S2A_1UCR_20210124_0_L1C',
'S2B_22WEB_20200612_0_L1C',
'S2A_22XEQ_20190610_10_L1C',
'LC08_L1TP_009011_20200820_20200905_02_T1',
'LO08_L1GT_043001_20201106_20201110_02_T2',
'LC09_L1GT_215109_20220125_20220125_02_T2',
Expand Down Expand Up @@ -299,6 +300,12 @@ def test_submit_bad_autorift_granule_names(client):
# bad L8 sensor mode
'LT08_L1GT_041001_20200125_20200925_02_T2',
'LT09_L1GT_215109_20220125_20220125_02_T2',
# S2 name too long
'S2B_22XEQ_20190610_11_XL1C',
'S2A_22XEQ_20190610_10_XL1C',
asjohnston-asf marked this conversation as resolved.
Show resolved Hide resolved
# S2 name too short
'S2B_22XEQ_20190610_L1C',
'S2A_22XEQ_20190610_L1C',
]
for granule in bad_granule_names:
batch = [
Expand Down