Skip to content

Commit

Permalink
add asu_components_appearance and fix error
Browse files Browse the repository at this point in the history
  • Loading branch information
tbutterf committed Nov 8, 2024
1 parent 6415639 commit 41019c7
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/mono-package-split.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ name: 'Split ASU Packages'
on:
push:
branches:
- main
tags:
- 'v[0-9]+.[0-9]+.[0-9]+'
- WS2-1623
# tags:
# - 'v[0-9]+.[0-9]+.[0-9]+'
# Allow us to manually trigger the workflow
workflow_dispatch:

Expand All @@ -34,6 +34,8 @@ jobs:
split_repository: asu_react_integration
- local_path: web/modules/asu_modules/asu_config_utility
split_repository: asu_config_utility
- local_path: web/modules/asu_modules/asu_components_appearance
split_repository: asu_components_appearance

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion web/modules/asu_modules/asu_brand/asu_brand.module
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function asu_brand_form_alter(&$form, FormStateInterface $form_state, $form_id)
$form['links']['links']['#header'][] = t("Header settings");
foreach (Element::children($form['links']['links']) as $key => $child) {
$link_parts = explode(':', $child);
if ($link_parts[2] && Uuid::isValid($link_parts[2])) { // TODO Is there a better check we can do here?
if (count($link_parts) > 2 &&$link_parts[2] && Uuid::isValid($link_parts[2])) { // TODO Is there a better check we can do here?
$link_uuid = $link_parts[2];
$link_entity = \Drupal::service('entity.repository')
->loadEntityByUuid('menu_link_content', $link_uuid);
Expand Down
3 changes: 2 additions & 1 deletion web/modules/asu_modules/asu_brand/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"require": {
"asuwebplatforms/asu_react_core": "^2.14",
"asuwebplatforms/asu_react_integration": "^2.14",
"asuwebplatforms/asu_user": "^2.14"
"asuwebplatforms/asu_user": "^2.14",
"asuwebplatforms/asu_components_appearance": "^2.14"
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: ASU Components Appearance
description: Provides dynamic appearance changes for the ASU components
description: Provides dynamic appearance changes for the ASU components.
type: module
core_version_requirement: ^8 || ^9 || ^10
core_version_requirement: ^10
package: ASU
dependencies:
- drupal:field_group

0 comments on commit 41019c7

Please sign in to comment.