Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable masks color and default brush color #12326

Merged

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Aug 5, 2023

Oh my eyes my eyes
I'm blinded by the Light

Description

682ff89 I know you're overjoyed
but at least make it consistent and configurable

the default brush color for the color sketch is not important, as we have a color picker built into the tool
but since you changed it on Inpaint sketch and not for sketch I decide to annoy you to put all three options in

and set the default color black to annoy you, change it to white if you want

unfortunately I don't think there is a color picker on the noirmal sketch tool (only on the color-sketch)
so we cannot change the mask brush color during use
and the mask color is not updated by the settings immediately and requires a Reload
maybe it's achievable if we do some messing around with JavaScript

able to change the transparent mask color is important
as depending on what images you're working on some mask color may not be suited

Screenshots/videos:

before pr

2023-08-05.08_44_11_043.chrome.mp4

after PR
image

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner August 5, 2023 00:46
@AUTOMATIC1111
Copy link
Owner

It's a great idea but turn those zeros into ones. Also use .needs_restart() function like in option lines above.

@AUTOMATIC1111 AUTOMATIC1111 merged commit 63cac3c into dev Aug 5, 2023
@AUTOMATIC1111 AUTOMATIC1111 deleted the configurable-masks-color-and-default-brush-color- branch August 5, 2023 06:34
@w-e-w w-e-w mentioned this pull request Aug 24, 2023
@MaxMagnos
Copy link

Is there a way to turn off the transparency? I use auto1111 with cloud-inference and that only works with the default JPEG format, so the transparent mask completely broke Inpainting for Cloud Inference.

@w-e-w
Copy link
Collaborator Author

w-e-w commented Sep 4, 2023

Is there a way to turn off the transparency? I use auto1111 with cloud-inference and that only works with the default JPEG format, so the transparent mask completely broke Inpainting for Cloud Inference.

@MaxMagnos
what dose cloud-inference have to do with a completely visual GUI setting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants