Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't save incomplete images #12338

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Aug 5, 2023

Description

[Feature Request]: Option setting to not save a skipped image #12335

not exactly what the feature request asked, he's asking for interactive implementation....

new opt Saving images/grids > Don't save incomplete images
image
if enabled will skip saving to storage when the image is interrupted or skipped
default not enabled

saving of image grid is not affected it's not governed under this setting
and even if the images are not saved the result was still show up in web UI

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner August 5, 2023 08:27
@w-e-w w-e-w linked an issue Aug 5, 2023 that may be closed by this pull request
1 task
@AUTOMATIC1111
Copy link
Owner

AUTOMATIC1111 commented Aug 5, 2023

There's another PR that I keep putting off that does something similar...

#8608

This one's a lot shorter so that's great.

opts.samples_save and not p.do_not_save_samples and not (opts.dont_save_incomplete_images and (state.interrupted or state.skipped)) should probably be made into an inline function

@w-e-w
Copy link
Collaborator Author

w-e-w commented Aug 5, 2023

yeah I'll make it into a function so that it's easier to reuse and more readable
don't know why I didn't think of that

@w-e-w w-e-w marked this pull request as draft August 5, 2023 09:12
@AUTOMATIC1111
Copy link
Owner

or just calculated and put into variable

@w-e-w w-e-w force-pushed the dont-save-incomplete-images branch from b9b0fd6 to 56d9319 Compare August 5, 2023 09:39
@w-e-w w-e-w marked this pull request as ready for review August 5, 2023 09:41
@w-e-w w-e-w marked this pull request as draft August 5, 2023 09:43
@w-e-w w-e-w force-pushed the dont-save-incomplete-images branch from 56d9319 to 26619e5 Compare August 5, 2023 09:46
@w-e-w w-e-w marked this pull request as ready for review August 5, 2023 09:47
@w-e-w w-e-w marked this pull request as draft August 5, 2023 09:48
@w-e-w w-e-w force-pushed the dont-save-incomplete-images branch from 26619e5 to 1d7dcdb Compare August 5, 2023 10:08
@w-e-w w-e-w marked this pull request as ready for review August 5, 2023 10:08
@w-e-w
Copy link
Collaborator Author

w-e-w commented Aug 5, 2023

should be good this time
the function is used once for high-respass
for saving the normal pipeline it is calculated once then save to a var

@AUTOMATIC1111 AUTOMATIC1111 merged commit 2844d95 into dev Aug 6, 2023
@AUTOMATIC1111 AUTOMATIC1111 deleted the dont-save-incomplete-images branch August 6, 2023 03:05
@AUTOMATIC1111
Copy link
Owner

opts.save is a function that writes config to file; it is always not False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Option setting to not save a skipped image
2 participants