Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Lora/Networks: use old method option #12466

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

catboxanon
Copy link
Collaborator

@catboxanon catboxanon commented Aug 11, 2023

Description

Closes #12104

Fixes a regression introduced by b75b004 as part of the extra networks rework (#11821). As far as I can tell this was just an oversight during refactoring. This fixes the RuntimeError and produces an image identical to one before this regression.

Note that this function is only ever used when the option is enabled, so it doesn't affect the "new normal" for LoRA operation.

def network_forward(module, input, original_forward):
"""
Old way of applying Lora by executing operations during layer's forward.
Stacking many loras this way results in big performance degradation.
"""

Checklist:

@catboxanon catboxanon changed the title Fix to make Lora/Networks: use old method setting work Fix broken Lora/Networks: use old method option Aug 11, 2023
@AUTOMATIC1111 AUTOMATIC1111 merged commit 2c79f2a into AUTOMATIC1111:dev Aug 11, 2023
@w-e-w w-e-w mentioned this pull request Aug 24, 2023
@catboxanon catboxanon deleted the fix/lora-old-mk2 branch March 4, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Generating using LoRA fails with Runtime Error with Lora/Networks: use old method enabled
2 participants