Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix potential ssrf attack in #12663 #12698

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix potential ssrf attack in #12663 #12698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion modules/api/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import time
import datetime
import uvicorn
import ipaddress
import requests
import gradio as gr
from threading import Lock
from io import BytesIO
Expand Down Expand Up @@ -56,8 +58,27 @@ def setUpscalers(req: dict):


def decode_base64_to_image(encoding):
def verify_url(url):
import socket
from urllib.parse import urlparse
try:
parsed_url = urlparse(url)
domain_name = parsed_url.netloc
host = socket.gethostbyname_ex(domain_name)
for ip in host[2]:
ip_addr = ipaddress.ip_address(ip)
# https://docs.python.org/3/library/ipaddress.html#ipaddress.IPv4Address.is_global
if not ip_addr.is_global:
return False
except Exception:
return False

return True

if encoding.startswith("http://") or encoding.startswith("https://"):
import requests
if not verify_url(encoding):
raise HTTPException(status_code=500, detail="Invalid image url")

response = requests.get(encoding, timeout=30, headers={'user-agent':'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36'})
try:
image = Image.open(BytesIO(response.content))
Expand Down