Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parenthesis auto selection #13829

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix parenthesis auto selection #13829

merged 1 commit into from
Nov 3, 2023

Conversation

missionfloyd
Copy link
Collaborator

Fixes #13813

Checklist:

@catboxanon catboxanon mentioned this pull request Nov 3, 2023
4 tasks
@catboxanon
Copy link
Collaborator

Probably should take a look at the case in #13533 (comment) because this still doesn't resolve that, with or without this change.

test <lora:name:1> doesn't function correctly when attempting to edit test as well.

@AUTOMATIC1111 AUTOMATIC1111 merged commit 1f373a2 into dev Nov 3, 2023
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the paren-fix branch November 3, 2023 16:59
@AUTOMATIC1111
Copy link
Owner

this was a bug by me, thanks

catboxanon:
test <lora:name:1> asdsadgvsacasdcsdf seems to work just fine for me - becomes (test:1.1) <lora:name:1> asdsadgvsacasdcsdf

@catboxanon
Copy link
Collaborator

@AUTOMATIC1111 I should've specified I'm not manually selecting the text, just placing the cursor there. This is the behavior I'm getting. With all extensions disabled and on latest dev commit. I have to revert back to https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/0b0767939d4cc0868a10b6c0978f7b2d963dea1a/javascript/edit-attention.js to get it to work properly.

firefox_2023-11-03_13-53-07.mp4

@catboxanon
Copy link
Collaborator

catboxanon commented Nov 3, 2023

Oh, it's my delimiters that weren't updated as part of 1cc7c4b ...
That's going to need a compatibility update here so it overwrites the setting if the user never modified it.

Edit: For the record, assigning it with the raw string didn't even work properly, and it ended up writing a literal \ followed by n for example. I had to manually modify the config.json. The way that ends up displaying in the settings interface isn't really clear at all though.

@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants