Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json.dump(ensure_ascii=False) #14108

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Nov 26, 2023

Description

json.dump(ensure_ascii=False) for lora metadata config cache.json ui-config config_states
improve readability especially useful for non English users

example lora metadata
from this

{
    "description": "",
    "sd version": "SD1",
    "activation text": "",
    "preferred weight": 0.5,
    "notes": "\u9019\u662f\u500b\u6e2c\u8a66"
}

to this

{
    "description": "",
    "sd version": "SD1",
    "activation text": "",
    "preferred weight": 0.5,
    "notes": "這是個測試"
}

Screenshots/videos:

Checklist:

improve json readability
@AUTOMATIC1111 AUTOMATIC1111 merged commit 500de91 into dev Nov 26, 2023
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the json.dump(ensure_ascii=False) branch November 26, 2023 13:15
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants