Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XYZ scripts / split hires path from unet #14126

Merged
merged 5 commits into from
Dec 2, 2023

Conversation

aria1th
Copy link
Collaborator

@aria1th aria1th commented Nov 27, 2023

Description

Supports XYZ options for Hypertile setups
Extends swap size option
Separates HR pass option from Unet option, so that hypertile can only work for hr pass

Hypertile has Swap size problem (as far as I know)

And as conclusion - I'd just let swap size to biggest one that we can use.

All images were generated with Blessed2 VAE, CuteYukiMix, with prompt 1girl, easynegative, nsfw
image

Here is example with 512x768 without any hr-pass.
image

With 1024x1536, of course it won't work without hr pass, so maybe with kohya's hires fix:
image

Or default
image

With swap size 1, we can observe significant artifacts which caused by 'unknown nearby pixels', splitted by hypertile.

By allowing bigger swap sizes, we can usually avoid the artifacts with minimal performance degradation.

(There will be additional patch to pre-calculate list of divisors and cache it too)

Also, I observed that LCM scheduler + LCM Lora will improve performance and reduce artifact in some aspect too.
(1024x1024 with kohya's hires fix, 10 step test)
image

Screenshots/videos:

image

1024x1408 with kohya hires fix
image

512x704, 2x hires fix with Anime6B (denoise 0.5):
image

Some close-up, almost no artifact for 512x704 + 2x hires fix

image

TODO : fix some code snippets, cache divisors

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 7547d7c into AUTOMATIC1111:dev Dec 2, 2023
3 checks passed
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants