reorder training preprocessing modules in extras tab #14367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #14360 Captions not being generated for flipped copies
since captioning is applied before flipping the image the flip the version of the image don't have captions
I reordered the five image training preprocessing modules using the order from before the rework 11d23e8
remove Train/Preprocessing tab and put all its functionality into extras batch images mode
(hopefully I didn't mess up the order)
personally I do not like 11d23e8
remove Train/Preprocessing tab and put all its functionality into extras batch images mode
I think the use case of
preprocessing images for training
andapplying additional effects such as upscaling among other things that extensions do such as color enhancement
are very different and should be separatedlots of people are not interested in training (or use other tools for training) would probably never uses preprocessing, for them this will be just cluttering the UI
the modules also cannot be disabled / hidden easily
personally I like the version before the rework, but I will have less of an issue if all these is grouped under a "big accordion"
there's also another issue caused by the rework
irrc before captioning was done in a single large batch as opposed to being processed separately
which means that you can just load and unload the model once reducing overhead
assuming that this is the only cause of the slowdown, then adding a function
before_batch_processing
andafter_batch_processing
can solve this issue, they can be used to load it unload the modelChecklist: