Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop basicsr dependency #14467

Merged
merged 4 commits into from
Dec 30, 2023
Merged

Drop basicsr dependency #14467

merged 4 commits into from
Dec 30, 2023

Conversation

akx
Copy link
Collaborator

@akx akx commented Dec 30, 2023

Description

Post #14425, we only used basicsr for img2tensor and tensor2img; this PR vendors the relevant bits (RGB tensors/images only, RGB<->BGR conversion always) into a couple of functions to get rid of basicsr as a direct dependency altogether.

I also noticed I'd screwed up with the typing for restore_face, so that gets fixed too.

Screenshots/videos:

None. I did double-check the test-outputs for face restoration, and they look like they did before. I also checked that the RGB/BGR conversion is necessary; they were very screwy otherwise. 😁

Checklist:

@w-e-w
Copy link
Collaborator

w-e-w commented Dec 30, 2023

it seems basicsr is used by realesrgan so it's going to be installed anyway

realesrgan==0.3.0
├── basicsr [required: >=1.4.2, installed: 1.4.2]

@akx
Copy link
Collaborator Author

akx commented Dec 30, 2023

@w-e-w
Copy link
Collaborator

w-e-w commented Dec 30, 2023

@w-e-w we don't depend on realesrgan since #14425 either :)

ohhh that's new

@akx akx marked this pull request as ready for review December 30, 2023 17:55
@AUTOMATIC1111 AUTOMATIC1111 merged commit 16848f9 into AUTOMATIC1111:dev Dec 30, 2023
3 checks passed
@AUTOMATIC1111
Copy link
Owner

There is possibility for some extension to break if it uses the library assuming webui requires it.

@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants