Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleLivePriview button in image viewer #16065

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Jun 21, 2024

Description

Add a button to toggle setting Show Live preview in full page image viewer in side image viewer

the value is setting is used as default
the toggle button javascript dose not write / updates the settings

I am not too happy with the choice of icon and it's positioning
if anyone has better suggestions

Screenshots/videos:

2024-06-21.20_31_48_078.chrome.mp4

some related ideas

  • Generate button inside image viewer
  • Hires fix upscall button inside image viewer (when on txt2img tab)
  • Hires fix upscall hotkey (when on txt2img tab)

Checklist:

@light-and-ray
Copy link
Contributor

light-and-ray commented Jun 25, 2024

Super, it works, but I can't understand how. Which part of the patch is responsible for sending previews into full-screen gallery? 😵‍💫

@light-and-ray
Copy link
Contributor

light-and-ray commented Jun 25, 2024

if anyone has better suggestions

Maybe 🗆/⧆. Asterisk in or not in square looks good for this

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jun 25, 2024

Super, it works, but I can't understand how. Which part of the patch is responsible for sending previews into gallery? 😵‍💫

that was something implemented long ago

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jun 25, 2024

it's possible to render emojis in black and white
maybe there are some good icons choices there

@AUTOMATIC1111 AUTOMATIC1111 merged commit 68df281 into dev Jul 6, 2024
6 checks passed
@lawchingman lawchingman mentioned this pull request Oct 5, 2024
@catboxanon catboxanon deleted the ToggleLivePriview-in-image-viewer branch November 1, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants