Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scala 2.12 cross-compiling #27

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Conversation

halotukozak
Copy link
Member

#25 requires scala 2.13 due to the math methods added in 2.13 version

@halotukozak halotukozak self-assigned this Aug 28, 2023
@halotukozak halotukozak marked this pull request as draft August 28, 2023 13:48
@halotukozak halotukozak marked this pull request as ready for review August 28, 2023 13:56
@ddworak
Copy link
Member

ddworak commented Aug 28, 2023

Did you check with other company teams regarding this change?

build.sbt Show resolved Hide resolved
@halotukozak
Copy link
Member Author

Did you check with other company teams regarding this change?

@pzareba22 asked them, it isn't used by anyone

Copy link
Member

@ddworak ddworak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be nice to follow-up later on in commons

@ddworak ddworak merged commit 1ce95b1 into master Aug 28, 2023
5 checks passed
@ddworak ddworak deleted the remove-2.12-scala-version branch August 28, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants