Email Command #57
Merged
Email Command #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
============================================
- Coverage 70.80% 70.41% -0.39%
- Complexity 397 400 +3
============================================
Files 74 75 +1
Lines 1298 1315 +17
Branches 129 130 +1
============================================
+ Hits 919 926 +7
- Misses 337 346 +9
- Partials 42 43 +1
Continue to review full report at Codecov.
|
chwoozy
reviewed
Mar 16, 2021
| StringBuilder concatenatedEmails = new StringBuilder(); | ||
| List<Student> studentList = model.getFilteredStudentList(); | ||
|
|
||
| for (Student stu : studentList) { |
There was a problem hiding this comment.
I think maybe we can use student instead of stu to improve readability
chwoozy
reviewed
Mar 16, 2021
| } | ||
|
|
||
| // third layer: check final message returned to user | ||
| String intendedMessage = Arrays.stream(emails).reduce("", (acc, el) -> acc + el + ";"); |
There was a problem hiding this comment.
Possibly change the use of `acc' and 'el' here too
chwoozy
approved these changes
Mar 16, 2021
enhao25
reviewed
Mar 16, 2021
|
Made changes mentioned by @YungWeezy @enhao25, merged! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15 - get all emails command via
emailsTo all:
Let me know if the command
emailsis suitable, i was consideringlist_emails, but seems to be too long andemailsmight be faster to type.This command also incorporates the copy to clipboard feature when they click on the result textarea/textbox. It will also copy when the user clicks for other commands, not sure if it'll be disruptive to the user in the future. If so, perhaps we can change it to double click? or other kind of available actions in javaFX. Think it's okay if we don't want this "copy to clipboard" feature as well since there's the default copy alr.
Let me know what y'all think! 📈