Skip to content

Commit

Permalink
Merge pull request #239 from shuyangk/branch-FinalTouches
Browse files Browse the repository at this point in the history
Finalise Shu Yang PPP
  • Loading branch information
yytan25 authored Nov 13, 2023
2 parents a92bd75 + 181d4b0 commit b647d3d
Showing 1 changed file with 19 additions and 11 deletions.
30 changes: 19 additions & 11 deletions docs/team/shuyangk.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,36 +9,44 @@ BandConnect++ is a desktop application that helps music producers seeking talent

Given below are my contributions to the project.

* **Code contributed**: [RepoSense link](https://nus-cs2103-ay2324s1.github.io/tp-dashboard/?search=shuyangk&breakdown=false&sort=groupTitle%20dsc&sortWithin=title&since=2023-09-22&timeframe=commit&mergegroup=&groupSelect=groupByRepos)


* **New Feature**: Edit Band Information.
* What it does: Allows users to edit information about a specific band, namely the name and genres of the band.
* Justification: It is important to be able to edit information that may be outdated in order to update it when changes occur.
* Highlights: This enhancement involved changing the structure of the Band class and the Commands associated with it to improve functionality.
* Credits: *I took inspiration from the existing edit command of AB3 and edited it to suit the context of the Band class*

* **Code contributed**: [RepoSense link](https://nus-cs2103-ay2324s1.github.io/tp-dashboard/?search=shuyangk&breakdown=false&sort=groupTitle%20dsc&sortWithin=title&since=2023-09-22&timeframe=commit&mergegroup=&groupSelect=groupByRepos)

* **Enhancements to existing features**:
* Removed the address field of the AB3 codebase.
* Removed the address field of the AB3 codebase [\#78](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/78).


* **Team tasks contributions**:
* Reviewed PRs of team members and gave constructive feedback
* Contributed to the UG and DG [\#88](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/88)
* Fix bugs of other features [\#149](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/149), [\#132](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/132)
* Fixed bugs of other features [\#149](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/149), [\#132](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/132)
* Wrote tests for multiple features [\#145](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/145), [\#207](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/207)
* Conducted post-PE-D bugs triage, commented on reports and fixed bugs.
* Managed releases `v1.2.1` and `v1.3` (2 releases) on GitHub.
* Maintained the issue tracker


* **Documentation**:
* User Guide:
* Added documentation for the `Band` class [\#88](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/88)
* Changed existing documentation various commands associated with `Band` class: [\#153](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/153/files)
* Developer Guide:
* Added documentation for the `Band` class [\#88](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/88).
* Changed existing documentation various commands associated with `Band` class: [\#153](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/153/files).
* Reformatted UG for ease of reading [\#214](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/214).
* Updated UG FAQ and Glossary sections [\#218](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/218)
* Developer Guide [\#88](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/88), [\#110](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/110):
* Added user stories [\#10](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/10).
* Included sequence and activity diagrams for multiple classes [\#213](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/213).
* Added add band, delete band documentation [\#114](https://github.com/AY2324S1-CS2103T-W11-3/tp/pull/114).

* **Community**:
* PRs reviewed (with non-trivial review comments): [\#29](https://github.com/nus-cs2103-AY2324S1/ip/pull/29), [\#52](https://github.com/nus-cs2103-AY2324S1/ip/pull/52)
* Contributed to forum discussions (To be added soon)

* **Tools**:
* To be added soon.
* **Community**:
* PRs reviewed (with non-trivial review comments): [\#29](https://github.com/nus-cs2103-AY2324S1/ip/pull/29), [\#52](https://github.com/nus-cs2103-AY2324S1/ip/pull/52).
* Participated in PE dry run and reported 10 bugs for team F13-3.


0 comments on commit b647d3d

Please sign in to comment.