Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester D] No error message for invalid CSV files #128

Closed
soc-se-bot opened this issue Apr 5, 2024 · 0 comments
Closed

[PE-D][Tester D] No error message for invalid CSV files #128

soc-se-bot opened this issue Apr 5, 2024 · 0 comments
Assignees
@tahsinhasem
Labels
severity.Low type.FunctionalityBug
Milestone
v1.4

Comments

@soc-se-bot
Copy link

I created a dummy csv with incorrect data and tried to import it.
On the user side, there is no input as to whether Student Contact Manager is currently importing, or facing an issue.
It'd be nice for the app to say "Invalid file" of some sorts.

Screenshot 2024-04-05 at 4.45.29 PM.png

Here is my csv:

Screenshot 2024-04-05 at 4.45.42 PM.png

Labels: type.FunctionalityBug severity.Low
original: officialchengyud/ped#10
@wilsonwid wilsonwid added this to the v1.4 milestone Apr 6, 2024
@tahsinhasem tahsinhasem self-assigned this Apr 7, 2024
tahsinhasem pushed a commit that referenced this issue Apr 15, 2024
@tah5in
Fix issue #128
9b96d5c
wilsonwid added a commit that referenced this issue Apr 15, 2024
@wilsonwid
Merge pull request #171 from AY2324S2-CS2103T-W08-3/csv-issue
784392e 
Fix issue #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tahsinhasem tahsinhasem

Labels
severity.Low type.FunctionalityBug
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
3 participants
@wilsonwid @soc-se-bot @tahsinhasem