Implement a command that lists ongoing schedules #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahsinhasem
requested changes
Apr 4, 2024
src/main/java/scm/address/logic/commands/ListOngoingScheduleCommand.java
Outdated
Show resolved
Hide resolved
* master: (50 commits) Added semicolon to separate regex Extracted out getPersonsFRomCsv Fixed EOF error for typicalSchedulesScheduleList.json Add more test coverage Add more test coverage Added test case to improve coverage of ImportCommand Added test cases for ParserUtil::parseFileForExport Fixed checkstyle for FileFormatTest Added tests for FileFormatTest Fix ERROR:../src/test/data/JsonScheduleStorageTest/typicalSchedulesScheduleList.json:12: no newline at EOF. error Fixed checkstyle errors bug fix Fix checkstyle errors Bug fix where files were not being exported to the correct path Applied fixes after merge Resolved all suggested changes Fix bug where app did not allow exporting contacts without a name added requireNonNull to getFileFormat Added filename and format checking to export command Removed "v/" argument. Changed Parser to parse file for export before allowing find and export command. ...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
============================================
+ Coverage 80.23% 80.29% +0.06%
- Complexity 703 706 +3
============================================
Files 105 106 +1
Lines 2206 2213 +7
Branches 212 212
============================================
+ Hits 1770 1777 +7
Misses 369 369
Partials 67 67 ☔ View full report in Codecov by Sentry. |
tahsinhasem
approved these changes
Apr 4, 2024
| requireNonNull(model); | ||
| LocalDateTime currentDateTime = LocalDateTime.now(); | ||
| DuringDateTimePredicate predicate = new DuringDateTimePredicate(Optional.of(currentDateTime)); | ||
| model.updateFilteredScheduleList(predicate); |
There was a problem hiding this comment.
Good job making the code more readable!!
| @@ -30,7 +30,7 @@ | |||
| public class FindScheduleCommandParser implements Parser<FindScheduleCommand> { | |||
| /** | |||
| * Parses the given {@code String} of arguments in the context of the FindScheduleCommand | |||
| * and returns a FindCScheduleCommand object for execution. | |||
| * and returns a FindScheduleCommand object for execution. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.