Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AddCommand to AddProjectCommand #22

Conversation

Lin-Shuang-Shuang
Copy link

No description provided.

Copy link

@modembcc modembcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version failed the checks. I've commented on the places the checks failed.

src/main/java/seedu/address/model/person/Person.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/storage/JsonAdaptedPerson.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/storage/JsonAdaptedPerson.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/ui/PersonCard.java Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.01%. Comparing base (302615f) to head (5cecfc6).
Report is 2 commits behind head on master.

Files Patch % Lines
.../address/logic/parser/AddProjectCommandParser.java 87.50% 1 Missing ⚠️
...c/main/java/seedu/address/model/person/Person.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
- Coverage     75.26%   72.01%   -3.25%     
+ Complexity      419      385      -34     
============================================
  Files            71       71              
  Lines          1338     1265      -73     
  Branches        126      114      -12     
============================================
- Hits           1007      911      -96     
- Misses          301      319      +18     
- Partials         30       35       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@modembcc modembcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The codecov test didn't pass, but we can fix it in the next week.

@modembcc modembcc added this to the DevPlan Pro v1.2 milestone Mar 11, 2024
@modembcc modembcc merged commit f80ac43 into AY2324S2-CS2103T-W08-4:master Mar 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants