Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delete Project Command #34

Merged

Conversation

modembcc
Copy link

  • add "delete project" command and update the logic
  • remove the old delete command
  • remove unused imports
  • remove filter list test cases
  • update test for delete project command and delete project command parser
  • change logic from using index to using string and looping through the list

Filtered Lists have been removed from the delete command tests as there is no filter function in v1.2.

The arguement has been changed from using index to using string and searching through the list.
@modembcc modembcc added this to the v1.2 milestone Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (f80ac43) to head (7275290).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
+ Coverage     72.01%   72.06%   +0.05%     
- Complexity      385      388       +3     
============================================
  Files            71       71              
  Lines          1265     1271       +6     
  Branches        114      117       +3     
============================================
+ Hits            911      916       +5     
- Misses          319      320       +1     
  Partials         35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Lin-Shuang-Shuang Lin-Shuang-Shuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@modembcc modembcc merged commit 666ec5d into AY2324S2-CS2103T-W08-4:master Mar 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants