Update success message after a linkloan command #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
=========================================
Coverage 49.57% 49.57%
Complexity 431 431
=========================================
Files 96 96
Lines 2124 2124
Branches 213 213
=========================================
Hits 1053 1053
Misses 1027 1027
Partials 44 44 ☔ View full report in Codecov by Sentry. |
Joseph31416
approved these changes
Apr 3, 2024
|
|
||
| return new CommandResult(String.format(MESSAGE_SUCCESS, Messages.format(targetPerson))); | ||
| return new CommandResult(String.format(MESSAGE_SUCCESS, targetPerson.getName(), | ||
| linkedLoan)); |
There was a problem hiding this comment.
Nice addition of better success message.
Joseph31416
merged commit 6cc2dc7
into
AY2324S2-CS2103T-W13-1:master
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96.
Now when a
linkloancommand is executed, the person name will be shown, followed by the loan details in the next line.E.g.