Implement defensive command access #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On person tab: No access to loan commands based on loan index. - On view all loans tab: No access to person commands based on person index. - On view loan of a person tab: Can only modify the person whose loan is being shown - On analytics tab: No access to loan and person commands based on index.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
============================================
+ Coverage 46.76% 46.90% +0.14%
- Complexity 432 433 +1
============================================
Files 99 99
Lines 2269 2275 +6
Branches 227 227
============================================
+ Hits 1061 1067 +6
Misses 1163 1163
Partials 45 45 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #97 and #110.
Defensive command access is implemented with the following features:
Special case:
When one
viewloana person anddeletethe person on that tab, one is redirected to the person tab with an empty list of persons. This modelled on the case whenfindonly returns one person: If onedeletethis person, the person list will be blank.