Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update editloan command to correctly show error message for invalid values #119

Conversation

kjw142857
Copy link

Fixes #115.

  • When the editloan command is entered with an invalid loan value (e.g. -1), an error message is now correctly show similar to linkloan.
  • The parseLoan command has also been greatly simplified due to duplication of code with parseValue and parseDate.

@kjw142857 kjw142857 added priority.High Must do type.Bug A bug severity.Medium Occasional inconvenience to some users labels Apr 4, 2024
@kjw142857 kjw142857 added this to the v1.3 milestone Apr 4, 2024
@kjw142857 kjw142857 self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 47.06%. Comparing base (e66deea) to head (2ccde5c).
Report is 2 commits behind head on master.

Files Patch % Lines
...in/java/seedu/address/logic/parser/ParserUtil.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #119      +/-   ##
============================================
+ Coverage     46.90%   47.06%   +0.16%     
  Complexity      433      433              
============================================
  Files            99       99              
  Lines          2275     2267       -8     
  Branches        227      227              
============================================
  Hits           1067     1067              
+ Misses         1163     1155       -8     
  Partials         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Joseph31416 Joseph31416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Joseph31416 Joseph31416 merged commit c7c759e into AY2324S2-CS2103T-W13-1:master Apr 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do severity.Medium Occasional inconvenience to some users type.Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing a loan to a negative value removes the loan and causes an assertion error
2 participants