Implement analytics GUI (Part 2 - Piechart Display) #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encapsulate analytics and benchmark values in a singular class
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
============================================
- Coverage 48.81% 47.34% -1.48%
Complexity 431 431
============================================
Files 98 99 +1
Lines 2157 2224 +67
Branches 216 224 +8
============================================
Hits 1053 1053
- Misses 1060 1127 +67
Partials 44 44 ☔ View full report in Codecov by Sentry. |
Joseph31416
reviewed
Apr 4, 2024
| if (analytics.getEarliestReturnDate() == null || earliestReturnDate == null) { | ||
| return null; | ||
| } | ||
| LocalDate target = analytics.getEarliestReturnDate().toInstant().atZone(ZoneId.systemDefault()).toLocalDate(); |
There was a problem hiding this comment.
We should probably abstract this conversion of dates in a later iteration.
| impactChart.setData(impactData); | ||
| impactIndex.setText(String.format("%.2f", data.getImpactIndex() * 100) + "%"); | ||
| } | ||
| if (data.getUrgencyIndex() == null) { |
There was a problem hiding this comment.
There's probably a better to handle these null conditions. Something to consider for future iterations.
Joseph31416
merged commit 2cdf8d3
into
AY2324S2-CS2103T-W13-1:master
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #84
Feature added
A GUI display for analytics has been implemented. It showcases 3 values in piecharts - Reliability, Impact and Urgency
Changelog
DashboardDatahas been added to encapsulate current contact's analytics and the max values of all existing loans. These max values are used for reference in calculating Impact and Urgency indicesNotes
Currently handled cases