Skip to content

Commit

Permalink
Auto merge of rust-lang#102991 - Sp00ph:master, r=scottmcm
Browse files Browse the repository at this point in the history
Update VecDeque implementation to use head+len instead of head+tail

(See rust-lang#99805)

This changes `alloc::collections::VecDeque`'s internal representation from using head and tail indices to using a head index and a length field. It has a few advantages over the current design:
* It allows the buffer to be of length 0, which means the `VecDeque::new` new longer has to allocate and could be changed to a `const fn`
* It allows the `VecDeque` to fill the buffer completely, unlike the old implementation, which always had to leave a free space
* It removes the restriction for the size to be a power of two, allowing it to properly `shrink_to_fit`, unlike the old `VecDeque`
* The above points also combine to allow the `Vec<T> -> VecDeque<T>` conversion to be very cheap and guaranteed O(1). I mention this in the `From<Vec<T>>` impl, but it's not a strong guarantee just yet, as that would likely need some form of API change proposal.

All the tests seem to pass for the new `VecDeque`, with some slight adjustments.

r? `@scottmcm`
  • Loading branch information
bors committed Nov 28, 2022
2 parents 36ab1bd + 1de3c7c commit 9fd7f7e
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 9fd7f7e

Please sign in to comment.