use env configuration for base URL, at http only to set cookie options #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisher60
force-pushed
the
fix/api-base-url
branch
from
7c6acfb
to
1497ce7
Compare
GDWR
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local dev was limited to port 8000, but we already have a config option available for the abandon auth.
I have also adjusted the cookie policy for the shared domain. We no longer need to specify the domain in the cookie since the cookie provider is also on the client domain in production. This should also allow us to use http only in our cookie options, but I haven't tested this yet, so there is only one way to find out >:)
closes #135