-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add provider checking based on model name and provider #571
Conversation
MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. This pull request introduces important updates to handle provider checking based on model names and providers dynamically. The changes are well thought out, particularly in handling different providers and ensuring that the API calls are guarded against common errors. However, there are a few areas where the implementation could be improved for clarity, error handling, and user guidance. Addressing these points will make the code more robust and user-friendly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed but it might be better to do in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I guess another thing to do in another PR is upgrade to 0.2 spice
No description provided.